Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand guidance on late-rendering for hooks #2818

Open
1 task done
jtcohen6 opened this issue Feb 3, 2023 · 0 comments
Open
1 task done

Expand guidance on late-rendering for hooks #2818

jtcohen6 opened this issue Feb 3, 2023 · 0 comments
Assignees
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear paper cut Common point of confusion, resulting in frequent threads or duplicate issues

Comments

@jtcohen6
Copy link
Collaborator

jtcohen6 commented Feb 3, 2023

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/resource-configs/pre-hook-post-hook
https://docs.getdbt.com/docs/building-a-dbt-project/dont-nest-your-curlies#an-exception

What part(s) of the page would you like to see updated?

This is one of my least favorite things in dbt. It should not be considered a "happy path." And yet we get issues about it all the time:

Specifically, if you want to:

  • include a {{ ref() }} or {{ source() }} call within a hook
  • access {{ this.type }} inside a hook
  • call a macro within a hook
  • conditionally set and use a variable inside a hook

It would be great, during dbt-core issue triage, to have a clear set of documentation (with examples) to pass along. Even though this is not a pattern we recommend, exactly, it does unlock some intermediate/advanced use cases for a handful of users.

Additional information

No response

@jtcohen6 jtcohen6 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Feb 3, 2023
@jtcohen6 jtcohen6 added the paper cut Common point of confusion, resulting in frequent threads or duplicate issues label Feb 7, 2023
@runleonarun runleonarun added the dbt Core The changes proposed in this issue relate to dbt Core label Jan 3, 2024
@runleonarun runleonarun added this to the dbt Core Documentation milestone Feb 29, 2024
@matthewshaver matthewshaver self-assigned this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear paper cut Common point of confusion, resulting in frequent threads or duplicate issues
Projects
None yet
Development

No branches or pull requests

3 participants