-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for derived offset filters #1531
Draft
courtneyholcomb
wants to merge
6
commits into
main
Choose a base branch
from
court/derived-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+5,151
−2,763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
courtneyholcomb
force-pushed
the
court/extraneous
branch
from
November 14, 2024 18:57
1d9c60f
to
4d89a9f
Compare
courtneyholcomb
force-pushed
the
court/derived-filter
branch
2 times, most recently
from
November 14, 2024 19:51
87076d9
to
9b3d1c0
Compare
courtneyholcomb
commented
Nov 14, 2024
ON | ||
subq_17.listing = listings_latest_src_28000.listing_id | ||
) subq_21 | ||
WHERE (((((metric_time__year >= '2020-01-01') AND (listing IS NOT NULL)) AND (metric_time__month >= '2019-01-01')) AND (booking__is_instant)) AND (booking__ds__quarter = '2021-01-01')) AND (listing__created_at__day = '2021-01-01') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this actually broken?
courtneyholcomb
force-pushed
the
court/derived-filter
branch
2 times, most recently
from
November 15, 2024 03:36
41b1d84
to
528c8dc
Compare
courtneyholcomb
changed the title
WIP - debug issues with derived offset metric filters
Bug fix for derived offset filters
Nov 15, 2024
courtneyholcomb
force-pushed
the
court/derived-filter
branch
from
November 15, 2024 06:37
f04f66c
to
60624bc
Compare
courtneyholcomb
force-pushed
the
court/derived-filter
branch
from
November 15, 2024 18:12
60624bc
to
2d5361f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.