Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature-gate bus implementation API #480

Closed
zeenix opened this issue Sep 25, 2023 · 3 comments · Fixed by #573
Closed

Feature-gate bus implementation API #480

zeenix opened this issue Sep 25, 2023 · 3 comments · Fixed by #573
Labels
api break zbus Issues/PRs related to zbus crate
Milestone
zbus-4.0

Comments

@zeenix
Copy link
Contributor

zeenix commented Sep 25, 2023

Typical user does not need some of the API provided for bus implementations. Let's feature-gate that so in most builds, this API is automatically removed.
@zeenix zeenix added api break zbus Issues/PRs related to zbus crate labels Sep 25, 2023
@zeenix zeenix added this to the zbus-4.0 milestone Sep 25, 2023
@TTWNO
Copy link
Contributor

TTWNO commented Oct 26, 2023

Where is bus-impl? I'm willing to setup a PR if you can trust me not to disappear for a few days again, haha!

@zeenix
Copy link
Contributor Author

zeenix commented Oct 26, 2023 •
edited
Loading

Where is bus-impl?

The task is to add it. You'll have to search through the docs/commit history to find out API (e.g Connection::set_unique_name). It's not the best task to pick randomly, I'm afraid.

@zeenix zeenix changed the title Feature-gate bus-impl API Feature-gate bus implementation API Oct 26, 2023
@zeenix zeenix modified the milestones: zbus-4.0, zbus-5.0 Jan 27, 2024
@zeenix
Copy link
Contributor Author

zeenix commented Jan 27, 2024 •
edited
Loading

4.0 is late and this isn't super important so removing it from 4.0 milestone.

@zeenix zeenix modified the milestones: zbus-5.0, zbus-4.0 Feb 7, 2024
zeenix added a commit to zeenix/zbus that referenced this issue Feb 7, 2024
@zeenix
🚩 zb: Add bus-impl cargo feature
6c03822 
API that is only needed by bus implementations now gated behind this
non-default cargo feature.

Fixes dbus2#480.
@zeenix zeenix mentioned this issue Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api break zbus Issues/PRs related to zbus crate
Projects
None yet
Milestone
zbus-4.0
Development

Successfully merging a pull request may close this issue.

🚩 zb: Add bus-impl cargo feature zeenix/zbus
2 participants
@zeenix @TTWNO