Replace winapi with windows-sys

[russellbanks]

winapi hasn't been updated in over 3 years. windows-sys is an official Microsoft crate that is actively maintained. I can have a go at the migration and create a pull request if this is an acceptable change.

[zeenix]

Sounds good! However, perhaps best use the high-level windows crate?

[russellbanks]

Unless there's anything specifically needed in the higher level crate, windows-sys is generally preferable in libraries because it has faster compile times and doesn't depend on std. Anecdotally, it's also more similar to winapi's API and has been very simple to migrate - hwchen/keyring-rs#159.

windows-or-windows-sys

[zeenix]

@russellbanks thanks for explaining. Sure, let's go for windows-sys.

[zeenix]

@russellbanks thanks for explaining. Sure, let's go for windows-sys.

@russellbanks Hi, I'm getting a strange panic from windows-sys against nightly (only) in busd tests. Looking at the relevant code in zbus, I don't see what's causing it. Also, it makes me rethink using -sys crate directly.

Ideas?

[zeenix]

@russellbanks Hi, I'm getting a strange panic from windows-sys against nightly (only) in busd tests. Looking at the relevant code in zbus, I don't see what's causing it. Also, it makes me rethink using -sys crate directly.

Ideas?

Filed an issue and I think I found a fix.