-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanding the number of players/clubs/competitions included in the hosted instance #51
Comments
@tvqt - Thanks for the suggestion. I haven't really tried to scrape non EU and lower level leagues, but I'd assume that's possible without changing the scraper by providing appropriate parameters / parent files. Is you question whether all this leagues could be added to the datasets? If so, perhaps we can discuss in a new issue in https://github.com/dcaribou/transfermarkt-datasets |
@dcaribou, hi! And thanks for the nice product. |
Hey @visheugene. There's not an explicit limit on the number of competitions scraped by the The reason why it scrapes the first page only is that it was simple enough and it already covered most relevant competitions (top 25 countries by market cap), so I stopped there. It should not be too hard to modify the competitions scraper so it recurses through the rest of the pages in the competitions list though, it that's needed. |
Hey @dcaribou, Would you be able to help me with modifying the scraper so it recurses through the rest of the pages in the competitions list? I'm having difficulties setting this up. |
Hey @ScottishWolverine. Sure. If you are having problems settings things up you may raise a new issue describing your problem. |
I've been joining the data on the FIFA 23 player database, and only about half of the players in the FIFA database are present in the scraped Transfermarkt data. The rest are on Transfermarkt data, but not scraped. These fall into a few different categories:
This works out to be about 10,000 players, so it would be great to find a way of incorporating them (if it doesn't make it too unwieldy!)
The text was updated successfully, but these errors were encountered: