You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
first up - thanks for doing this driver!
i had some issues getting my fans to work reliably - in particular i regularly had fan state issues.
i took a look at your code and figured it out.
(1) POLLING SCHEDULE: it had not occurred to me that the max. I could enter in the Polling Interval field would be 59 seconds , being a limitation based on the format of the schedule method. i'm super wary of constant polling - particularly as this is using sync HTTP calls - so i entered 120 seconds for the polling interval, and of course the schedule errored out but the UI gave no indication. so to allow for longer intervals, and also for non-coders (and coders who should know better - thats me BTW) i thought i'd add a minutes field and also tweak the input field descriptions.
(2) the BOND to HE command translations did not cater for 1 speed, which some of my fans had, so none of the commands would work. i added a 'one speed' option to the maps in the 2 methods.
a couple minor tweaks and 'issues' they are no more, they're pretty darn minor and tested OK....i have simply collated the changed methods in a .txt file, which you can compare to your original (I am on HPM, so was using the latest version with the latest revision in comments being:
"2020.06.28 - Added toggle command to all devices (suggested by jchurch) and support for having multiple Smart by BOND devices (discovered by jhciotti)"
if you could add these suggestions that would be great, provided you have no issues including them. Suggested Mods to BOND home.txt
The text was updated successfully, but these errors were encountered:
first up - thanks for doing this driver!
i had some issues getting my fans to work reliably - in particular i regularly had fan state issues.
i took a look at your code and figured it out.
(1) POLLING SCHEDULE: it had not occurred to me that the max. I could enter in the Polling Interval field would be 59 seconds , being a limitation based on the format of the schedule method. i'm super wary of constant polling - particularly as this is using sync HTTP calls - so i entered 120 seconds for the polling interval, and of course the schedule errored out but the UI gave no indication. so to allow for longer intervals, and also for non-coders (and coders who should know better - thats me BTW) i thought i'd add a minutes field and also tweak the input field descriptions.
(2) the BOND to HE command translations did not cater for 1 speed, which some of my fans had, so none of the commands would work. i added a 'one speed' option to the maps in the 2 methods.
a couple minor tweaks and 'issues' they are no more, they're pretty darn minor and tested OK....i have simply collated the changed methods in a .txt file, which you can compare to your original (I am on HPM, so was using the latest version with the latest revision in comments being:
"2020.06.28 - Added toggle command to all devices (suggested by jchurch) and support for having multiple Smart by BOND devices (discovered by jhciotti)"
if you could add these suggestions that would be great, provided you have no issues including them.
Suggested Mods to BOND home.txt
The text was updated successfully, but these errors were encountered: