CLI: Reuse specified root name in pbjs to be able to split definition…

…s over multiple files more easily, see #653
protobufjs · Jan 24, 2017 · 3a05624 · 3a05624
1 parent 301f776
commit 3a05624
Show file tree

Hide file tree

Showing 13 changed files with 20 additions and 21 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,3 +1,4 @@
 {
-    "typescript.tsdk": "./node_modules/typescript/lib"
+    "typescript.tsdk": "./node_modules/typescript/lib",
+    "vsicons.presets.angular": false
 }
diff --git a/cli/targets/static.js b/cli/targets/static.js
@@ -39,7 +39,8 @@ function static_target(root, options, callback) {
             else
                 push("// Exported root namespace");
         }
-        push("var $root = {};");
+        var rootName = config.root || "default";
+        push("var $root = $protobuf.roots[" + JSON.stringify(rootName) + "] || ($protobuf.roots[" + JSON.stringify(rootName) + "] = {});");
         buildNamespace(null, root);
         push("");
         if (config.comments)

diff --git a/cli/util.js b/cli/util.js
@@ -124,7 +124,6 @@ exports.wrap = function(OUTPUT, options) {
         // otherwise fetch the custom one
         wrap = fs.readFileSync(path.resolve(process.cwd(), name)).toString("utf8");
     }
-    wrap = wrap.replace(/%ROOT%/g, JSON.stringify(options.root || "default"));
     wrap = wrap.replace(/%DEPENDENCY%/g, JSON.stringify(options.dependency || "protobufjs"));
     wrap = wrap.replace(/( *)%OUTPUT%/, function($0, $1) {
         return $1.length ? OUTPUT.replace(/^/mg, $1) : OUTPUT;

diff --git a/cli/wrappers/amd.js b/cli/wrappers/amd.js
@@ -3,5 +3,5 @@ define(["protobuf"], function($protobuf) {
 
     %OUTPUT%
 
-    return $protobuf.roots[%ROOT%] = $root;
+    return $root;
 });
diff --git a/cli/wrappers/commonjs.js b/cli/wrappers/commonjs.js
@@ -4,4 +4,4 @@ var $protobuf = require(%DEPENDENCY%);
 
 %OUTPUT%
 
-module.exports = $protobuf.roots[%ROOT%] = $root;
+module.exports = $root;
diff --git a/cli/wrappers/default.js b/cli/wrappers/default.js
@@ -11,5 +11,5 @@
 
     %OUTPUT%
 
-    return $protobuf.roots[%ROOT%] = $root;
+    return $root;
 });
diff --git a/cli/wrappers/es6.js b/cli/wrappers/es6.js
@@ -2,6 +2,4 @@ import * as $protobuf from "protobufjs";
 
 %OUTPUT%
 
-$protobuf.roots[%ROOT%] = $root;
-
 export { $root as default };
diff --git a/tests/data/comments.js b/tests/data/comments.js
@@ -12,7 +12,7 @@ var $Reader = $protobuf.Reader,
 var $lazyTypes = [];
 
 // Exported root namespace
-var $root = {};
+var $root = $protobuf.roots["test_comments"] || ($protobuf.roots["test_comments"] = {});
 
 $root.Test1 = (function() {
 
@@ -47,7 +47,7 @@ $root.Test1 = (function() {
     Test1.prototype.field2 = 0;
 
     /**
-     * Field with a comment.
+     * Field with a comment and a <a href="http://example.com/foo/">link</a>
      * @type {boolean}
      */
     Test1.prototype.field3 = false;
@@ -377,4 +377,4 @@ $root.Test3 = (function() {
 // Resolve lazy type references to actual types
 $util.lazyResolve($root, $lazyTypes);
 
-module.exports = $protobuf.roots["test_comments"] = $root;
+module.exports = $root;
diff --git a/tests/data/convert.js b/tests/data/convert.js
@@ -12,7 +12,7 @@ var $Reader = $protobuf.Reader,
 var $lazyTypes = [];
 
 // Exported root namespace
-var $root = {};
+var $root = $protobuf.roots["test_convert"] || ($protobuf.roots["test_convert"] = {});
 
 $root.Message = (function() {
 
@@ -520,4 +520,4 @@ $root.Message = (function() {
 // Resolve lazy type references to actual types
 $util.lazyResolve($root, $lazyTypes);
 
-module.exports = $protobuf.roots["test_convert"] = $root;
+module.exports = $root;
diff --git a/tests/data/mapbox/vector_tile.js b/tests/data/mapbox/vector_tile.js
@@ -12,7 +12,7 @@ var $Reader = $protobuf.Reader,
 var $lazyTypes = [];
 
 // Exported root namespace
-var $root = {};
+var $root = $protobuf.roots["test_vector_tile"] || ($protobuf.roots["test_vector_tile"] = {});
 
 $root.vector_tile = (function() {
 
@@ -1182,4 +1182,4 @@ $root.vector_tile = (function() {
 // Resolve lazy type references to actual types
 $util.lazyResolve($root, $lazyTypes);
 
-module.exports = $protobuf.roots["test_vector_tile"] = $root;
+module.exports = $root;
diff --git a/tests/data/package.js b/tests/data/package.js
@@ -12,7 +12,7 @@ var $Reader = $protobuf.Reader,
 var $lazyTypes = [];
 
 // Exported root namespace
-var $root = {};
+var $root = $protobuf.roots["test_package"] || ($protobuf.roots["test_package"] = {});
 
 $root.Package = (function() {
 
@@ -824,4 +824,4 @@ $root.Package = (function() {
 // Resolve lazy type references to actual types
 $util.lazyResolve($root, $lazyTypes);
 
-module.exports = $protobuf.roots["test_package"] = $root;
+module.exports = $root;
diff --git a/tests/data/rpc.js b/tests/data/rpc.js
@@ -12,7 +12,7 @@ var $Reader = $protobuf.Reader,
 var $lazyTypes = [];
 
 // Exported root namespace
-var $root = {};
+var $root = $protobuf.roots["test_rpc"] || ($protobuf.roots["test_rpc"] = {});
 
 $root.MyService = (function() {
 
@@ -399,4 +399,4 @@ $root.MyResponse = (function() {
 // Resolve lazy type references to actual types
 $util.lazyResolve($root, $lazyTypes);
 
-module.exports = $protobuf.roots["test_rpc"] = $root;
+module.exports = $root;
diff --git a/tests/data/test.js b/tests/data/test.js
@@ -12,7 +12,7 @@ var $Reader = $protobuf.Reader,
 var $lazyTypes = [];
 
 // Exported root namespace
-var $root = {};
+var $root = $protobuf.roots["test_test"] || ($protobuf.roots["test_test"] = {});
 
 $root.jspb = (function() {
 
@@ -14121,4 +14121,4 @@ $root.google = (function() {
 // Resolve lazy type references to actual types
 $util.lazyResolve($root, $lazyTypes);
 
-module.exports = $protobuf.roots["test_test"] = $root;
+module.exports = $root;