Moved extend implementation to its own micromodule, might help with #560

; tsd-jsdoc progress
protobufjs · Dec 15, 2016 · 75f4b6c · 75f4b6c
1 parent a834250
commit 75f4b6c
Show file tree

Hide file tree

Showing 23 changed files with 378 additions and 109 deletions.
diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
@@ -3,13 +3,13 @@ protobuf.js version: <fill in>
 ### How to reproduce ###
 
 ```js
-<code snippet>
+<please add a code snippet>
 ```
 
-### Expected behaviour ###
+### Expected behavior ###
 
 <please describe>
 
-### Actual behaviour ###
+### Actual behavior ###
 
 <please describe>
diff --git a/cli/pbts.js b/cli/pbts.js
@@ -51,7 +51,7 @@ exports.main = function(args) {
 
     // There is no proper API for jsdoc, so this executes the CLI and pipes the output
     var basedir = path.join(__dirname, "..");
-    var moduleName = argv.name || "mymodule";
+    var moduleName = argv.name || "null";
     var child = child_process.exec("node \"" + basedir + "/node_modules/jsdoc/jsdoc.js\" -c \"" + basedir + "/jsdoc.types.json\" -q \"module=" + encodeURIComponent(moduleName) + "\" " + files.map(function(file) { return '"' + file + '"'; }).join(' '), {
         cwd: process.cwd(),
         argv0: "node",

diff --git a/dist/protobuf.js b/dist/protobuf.js
diff --git a/dist/protobuf.js.map b/dist/protobuf.js.map
diff --git a/dist/protobuf.min.js b/dist/protobuf.min.js
diff --git a/dist/protobuf.min.js.gz b/dist/protobuf.min.js.gz
diff --git a/dist/protobuf.min.js.map b/dist/protobuf.min.js.map
diff --git a/dist/runtime/protobuf.js b/dist/runtime/protobuf.js
diff --git a/dist/runtime/protobuf.js.map b/dist/runtime/protobuf.js.map
diff --git a/dist/runtime/protobuf.min.js b/dist/runtime/protobuf.min.js
diff --git a/dist/runtime/protobuf.min.js.gz b/dist/runtime/protobuf.min.js.gz
diff --git a/dist/runtime/protobuf.min.js.map b/dist/runtime/protobuf.min.js.map
diff --git a/lib/tsd-jsdoc/README.md b/lib/tsd-jsdoc/README.md
@@ -10,14 +10,14 @@ Options
   Wraps everything in a module of the specified name.
 
 * **private: `boolean`**<br />
-  Skips private members when set to `false`.
+  Includes private members when set to `true`.
 
 * **comments: `boolean`**<br />
-  Skips any comments when set to `false`.
+  Skips comments when explicitly set to `false`.
 
 * **destination: `string|boolean`**<br />
   Saves to the specified destination file or to console when set to `false`.
 
 Setting options on the command line
 -----------------------------------
-Providing `-q, --query <queryString>` on the command line will set respectively override existing options.
+Providing `-q, --query <queryString>` on the command line will set respectively override existing options. Example: `-q module=protobufjs`