Emit a maximum of one error var when generating verifiers, fixes #786

protobufjs · Jun 9, 2017 · f295979 · f295979
1 parent 3b848a1
commit f295979
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/verifier.js b/src/verifier.js
@@ -29,10 +29,13 @@ function genVerifyValue(gen, field, fieldIndex, ref) {
             gen
                     ("break")
             ("}");
-        } else gen
-            ("var e=types[%i].verify(%s);", fieldIndex, ref)
+        } else {
+            gen
+            ((gen.hasErrorVar ? "" : "var ") + "e=types[%i].verify(%s);", fieldIndex, ref)
             ("if(e)")
                 ("return%j+e", field.name + ".");
+            gen.hasErrorVar = true;
+        }
     } else {
         switch (field.type) {
             case "int32":