Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend list of ignored ESLint rules for pbjs #1085

Closed
bennycode opened this issue Jul 16, 2018 · 0 comments
Closed

Extend list of ignored ESLint rules for pbjs #1085

bennycode opened this issue Jul 16, 2018 · 0 comments

Comments

@bennycode
Copy link

The output, which pbjs generates, isn't compatible with the following ESLint rules:

  • id-length
  • no-magic-numbers
  • no-shadow
  • no-var
  • sort-vars

I suggest to add these rules to the eslint-disable header which is part of the generated output of pbjs.

Tested with "protobuf.js v6.7.0 CLI for JavaScript".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bennycode