Non deterministic code gen

[robin-anil]

protobuf.js version: 6.2.1

Runpbjs -p <path-to-protobuf> -t json -o something.json
Output is not deterministic on every run.
Please ensure that the tree traversal and code generated is in a sorted and determinstic fashion.

This creates huge diffs on every checkin. This was not the case in v5.

I am upgrading a 50K line client side code base with over 100 protos from 5 to 6.

[dcodeIO]

Unfortunately, I don't know where this could come from. Do you know if this affects specific parts / features of the generated output more than others?

[robin-anil]

I cannot discern where this is stemming from. I would think that a sorting would solve this issue.

[dcodeIO]

Had an idea: pbjs is using async load, which most likely results in files being loaded in different order for large code bases. Replacing that with loadSync should prevent it.

[robin-anil]

👍 Let me know when the fix is pushed. I will try it.

[paralin]

@dcodeIO just add a --sync flag or something

[dcodeIO]

Let me know if this fixes it!

[robin-anil]

Verified to be fixed