-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error using CLI with protobufjs installed in project due to missing semver #648
Comments
Ah, I didn't realize the behavior of the CLI util setup function installing missing CLI dependencies. The solution I have working at the moment is at: master...Kenny-House:semver-dependency I've separated the semver install into a specific case at the beginning of the setup, as opposed to being one of the cliDependencies. The exact semver version is checked and installed if it is missing or doesn't match. I'm happy to submit that as a PR, but I'm not familiar enough with this project's constraints and preferences to know if that solution is acceptable. |
… are present and bootstrap semver, see #648
Thanks, I've modified the setup stuff accordingly and implemented an explicit check for module directories. Let me know if this is working for you! |
Thanks @dcodeIO, the latest update works great! Closing the issue. |
protobuf.js version: 6.5.0
Attempting to use the pbjs CLI within a package to generate static module.
Error: Cannot find module 'semver'
is thrown. Note that pbjs is not installed globally in this instance.The issue appears to be that
semver
is not included as a dependency in the package.json (but is instead a devDependency).The text was updated successfully, but these errors were encountered: