Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RPCImplCallback type declaration - make Error optional #766

Closed
wants to merge 2 commits into from
Closed

fix RPCImplCallback type declaration - make Error optional #766

wants to merge 2 commits into from

Conversation

rossenassenov
Copy link

No description provided.

@dcodeIO
Copy link
Member

dcodeIO commented Apr 19, 2017

index.d.ts is a generated file and any changes will be overwritten on rebuild. Actual source location is: https://github.com/dcodeIO/protobuf.js/blob/master/src/rpc.js#L28

@param {Error|null} then, probably.

@rossenassenov rossenassenov mentioned this pull request Apr 19, 2017
Closed
@rossenassenov
Copy link
Author

rossenassenov commented Apr 19, 2017 •
edited
Loading

Oh, I see. It actually needs to be @param {Error} [error].

http://usejsdoc.org/tags-param.html#optional-parameters-and-default-values

@dcodeIO
Copy link
Member

dcodeIO commented Apr 20, 2017

But is it actually optional? It cannot be undefined. There is either an Error, or none (null).

@dcodeIO dcodeIO closed this in 23f4b99 Apr 20, 2017
@rossenassenov rossenassenov deleted the fix_index_dts branch April 20, 2017 18:39
@rossenassenov
Copy link
Author

thanks for the fix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossenassenov @dcodeIO