Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm package for 6.8.1 no longer has dist directory. #955

Closed
jrburke opened this issue Nov 28, 2017 · 4 comments
Closed

npm package for 6.8.1 no longer has dist directory. #955

jrburke opened this issue Nov 28, 2017 · 4 comments

Comments

@jrburke
Copy link

jrburke commented Nov 28, 2017

protobuf.js version: 6.8.1

The npm package for version 6.8.0 would get installed on disk with a dist/ directory in it that had the browser builds of protobuf.js. However, 6.8.1 no longer has the dist/ directory.

Is this by design or is it an npm publish error?

@dcodeIO
Copy link
Member

dcodeIO commented Nov 28, 2017

This is due to fixing #781 in a8376b5 including just the relevant files for npm usage. Do you need the dist files in there?

@jrburke
Copy link
Author

jrburke commented Nov 29, 2017

I can appreciate wanting to remove extra files from the npm package, like tests. For the dist/ files, that gets into what you want to support for the npm package in relation to front end/browser usage.

It is becoming more common for front end projects to use npm to manage their dependencies, and we were definitely using it that way for an ember project. I can see two pathways if you wanted to support npm packaging for front end protobufjs files:

  1. Keep the dist/ directory in the main protobufjs npm package.
  2. A separate npm package that only has the dists/ files in it for front end use.

I vote for 1) to keep it easy on publishing, but I am happy to use either.

Alternatively, if you do not think there should be an npm package for the built, front end protobufjs files, suggestions on how I might get versioned files I can download into my project is appreciated. Referencing it at runtime on the CDN is not an option for me because it is bundled with other modules for deployment.

@dcodeIO
Copy link
Member

dcodeIO commented Nov 29, 2017

Ok, 6.8.2 has the dist files again.

@dcodeIO dcodeIO closed this as completed Nov 29, 2017
@jrburke
Copy link
Author

jrburke commented Nov 29, 2017

Thank you very much! Confirmed that it works for my use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants