-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-D
option not working ?
#2
Comments
Interesting catch, thanks for reporting! I must admit I dont use -D myself, and have tested this approach only for the integer flags. Maybe I'm overlooking something though, as it seems the https://github.com/ddelange/yt/blob/0.2.2/yt/yt#L53 Will need to investigate further! |
Ok cool Ill take look as well |
Maybe it gets consumed (destination is set as expected), but then the OPTIND shift allows it to get consumed a second time in filling URLS, or something similar. Another possibility is removing the double quotes from here, just a hunch... https://github.com/ddelange/yt/blob/0.2.2/yt/yt#L154 |
I tried w/ and w/o quotes |
Maybe not fully fixed ? Im semi-intermediate with bash so Im happy to take a look tomorrow, no rush not a blocker. Heres the project im working on: https://github.com/the-real-adammork/yt-extension started tonight, made it so I can speed up my music digging workflow. Idea is to have the chrome extension send requests to the express server on localhost to download whatever audio is in the current tab (soundcloud/youtube). Right now it activates when you click the extension icon, I think I'll add keyboard shortcut as well. Im glad I came across your project seems like it improves on Thanks 🦾 |
Thanks for checking!! Fixed in Your project sounds really cool! The extension would definitely save clicks and make the flow more natural! If you encounter any bugs in the future, please let me know. And also feel free to tag me on your PRs or so if you need a second pair of eyes :) |
Just installed, and Im excited to use this project ! Exactly what I need for something. But when I use the
-D
option I get an error:Not a blocker for me I can pull from the default download directory but figured you might want to know.
Thanks for this project, starred it !
The text was updated successfully, but these errors were encountered: