Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-D option not working ? #2

Closed
the-real-adammork opened this issue Apr 24, 2021 · 7 comments · Fixed by #3 or #4
Closed

-D option not working ? #2

the-real-adammork opened this issue Apr 24, 2021 · 7 comments · Fixed by #3 or #4

Comments

@the-real-adammork
Copy link

Just installed, and Im excited to use this project ! Exactly what I need for something. But when I use the -D option I get an error:

Screen Shot 2021-04-24 at 2 17 25 AM

Not a blocker for me I can pull from the default download directory but figured you might want to know.

Thanks for this project, starred it !

@ddelange
Copy link
Owner

Interesting catch, thanks for reporting!

I must admit I dont use -D myself, and have tested this approach only for the integer flags. Maybe I'm overlooking something though, as it seems the /tmp arg is not consumed in this line, and instead gets passed to URLS a bit further down.

https://github.com/ddelange/yt/blob/0.2.2/yt/yt#L53

Will need to investigate further!

@the-real-adammork
Copy link
Author

the-real-adammork commented Apr 24, 2021

Ok cool Ill take look as well

@ddelange
Copy link
Owner

ddelange commented Apr 24, 2021

Maybe it gets consumed (destination is set as expected), but then the OPTIND shift allows it to get consumed a second time in filling URLS, or something similar.

Another possibility is removing the double quotes from here, just a hunch... https://github.com/ddelange/yt/blob/0.2.2/yt/yt#L154

@the-real-adammork
Copy link
Author

I tried w/ and w/o quotes

@ddelange
Copy link
Owner

Released 0.3.0, once the tap PR auto-merges, please run brew upgrade yt :)

@the-real-adammork
Copy link
Author

Screen Shot 2021-04-24 at 4 29 11 AM

Maybe not fully fixed ?

Im semi-intermediate with bash so Im happy to take a look tomorrow, no rush not a blocker.

Heres the project im working on:

https://github.com/the-real-adammork/yt-extension
https://github.com/the-real-adammork/yt-server

started tonight, made it so I can speed up my music digging workflow. Idea is to have the chrome extension send requests to the express server on localhost to download whatever audio is in the current tab (soundcloud/youtube).

Right now it activates when you click the extension icon, I think I'll add keyboard shortcut as well.

Im glad I came across your project seems like it improves on youtube-dl in all the ways Id like and the take from clipboard by default is really smart, that was actually part of my old script.

Thanks 🦾

@ddelange
Copy link
Owner

Thanks for checking!! Fixed in 0.3.1.

Your project sounds really cool! The extension would definitely save clicks and make the flow more natural!

If you encounter any bugs in the future, please let me know. And also feel free to tag me on your PRs or so if you need a second pair of eyes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants