-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go wrappers for MBA<2> #16
Conversation
Thank you for the contribution! Does it need any changes in the CMakeLists.txt to build the new test? |
I test manually by running |
install_manifest.txt | ||
compile_commands.json | ||
CTestTestfile.cmake | ||
_deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should not be a problem with out-of-source builds, but ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, I usually build out of build too. fixed it on autopilot..
Thanks again! |
thank you for the quick turnaround!! hope to contribute more in the future :) |
Thank you for open-sourcing this implementation! It had been a pleasure to work with on a Python project.
I wanted to use MBA<2> in Golang, so wrote these wrappers using
cgo
...Verified using tests (in
golang_mba_test.go
):test_mba.cpp
interp
Python example in the README, the Golang test then expects to generate the exact same values for the same inputs.This implementation also support the functionality through Python's
__repr__
via theString()
function on the Mba2 struct.I hope to continue contributing further fixes or enhancements in case those come up.
Thanks again for open sourcing!