Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add featured sponsors to Support DDEV page #45

Merged
merged 2 commits into from
Apr 22, 2023

Conversation

mattstein
Copy link
Sponsor Collaborator

@mattstein mattstein commented Apr 22, 2023

The Issue

#44 raised the issue of featured sponsors not appearing at all on the Support DDEV page’s “Sponsor Development” section.

How This PR Solves The Issue

This adds those featured sponsors to the beginning of that list and uses GitHub handles to make sure they’re not repeated.

Before and after:

Screen Shot 2023-04-21 at 06 29 12 PM@2x

💡 I thought it was a bug that Peter Kraume shows up twice, but he’s sponsoring both rfay and ddev.

It also does a few things that’ll make it easier to acknowledge sponsorship elsewhere:

  • Moves featured sponsor data out of a component and into a standalone featured-sponsors.json file that can be pulled into different contexts.
  • Includes a sponsor "type", currently "major" or "standard"—which ideally we could map to consistent sponsorship tiers. With that done, visual treatment in different situations could be easier to manage.
  • Adds square SVG logos for each sponsor where they were necessary, for more layout control. (Also easy to PR if I committed any brand guide offenses, though I tried to be careful.)

Manual Testing Instructions

Try it locally or check out the preview build.

Automated Testing Overview

n/a

Related Issue Link(s)

Release/Deployment Notes

n/a

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very ambitious approach, very impressive, thanks!

@mattstein mattstein merged commit 80fd475 into main Apr 22, 2023
@mattstein mattstein deleted the feature/support-featured-sponsors branch April 22, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants