Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 7.x.x and > throws context aware warning #68

Open
tehnorm opened this issue Dec 5, 2019 · 1 comment
Open

Electron 7.x.x and > throws context aware warning #68

tehnorm opened this issue Dec 5, 2019 · 1 comment

Comments

@tehnorm
Copy link

tehnorm commented Dec 5, 2019

When loading the segfault handler in Electron 7.x.x and greater there is a warning in the output:

(node:39360) Electron: Loading non context-aware native modules in the renderer process is deprecated and will stop working at some point in the future, please see https://github.com/electron/electron/issues/18397 for more information

Is this something that is tricky to have implemented? It doesn't look critical in the stable version of Electron but will stop working in the future. We really appreciate the utility of segfault-handler and the work that has gone into it.

No one on our team really understands what it would take to create a PR - we would be very happy to help test.

@kneth
Copy link
Collaborator

kneth commented Dec 6, 2019

The issue mentioned says that N-API or Context Awareness is required in the future. Currently we use NaN, so it will require a rewrite to use N-API. Luckily, the code base isn't so large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants