Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dplyr::storms from unit testing #1472

Closed
ddsjoberg opened this issue Feb 28, 2023 · 0 comments · Fixed by #1496
Closed

Remove dplyr::storms from unit testing #1472

ddsjoberg opened this issue Feb 28, 2023 · 0 comments · Fixed by #1496
Milestone
v1.7.1

Comments

@ddsjoberg
Copy link
Owner

We use the dplyr::storms in the unit testing. But this dataset was updated in the last dplyr release to include more storms, which resulted in failing tests. These have been updated for now, but we should remove it so future updates don't break us
@ddsjoberg ddsjoberg added this to the v1.8.0 milestone Mar 6, 2023
@ddsjoberg ddsjoberg modified the milestones: v1.8.0, v1.7.1 Apr 23, 2023
@ddsjoberg ddsjoberg mentioned this issue Apr 23, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7.1
Development

Successfully merging a pull request may close this issue.

updating precision in round2() ddsjoberg/gtsummary
1 participant
@ddsjoberg