Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0 Add arguments style_*(prefix, suffix) ? #1690

Closed
ddsjoberg opened this issue May 27, 2024 · 1 comment · Fixed by #2009
Closed

v2.0 Add arguments style_*(prefix, suffix) ? #1690

ddsjoberg opened this issue May 27, 2024 · 1 comment · Fixed by #2009
Milestone

Comments

@ddsjoberg
Copy link
Owner

This could simplify our lives in some places for sure

@ddsjoberg ddsjoberg added this to the v2.0.0 milestone Jun 23, 2024
@ddsjoberg ddsjoberg added the v2.0 🤞🤞 A nice-to-have for the v2.0 release label Jun 26, 2024
@ddsjoberg
Copy link
Owner Author

If/when we do add these arguments, we can update the default formatting functions for add_difference()

estimate_fun = list(
  c(all_continuous(), all_categorical(FALSE)) ~ label_style_sigfig(),
  all_dichotomous() ~ function(x) ifelse(is.na(x), NA_character_, paste0(style_sigfig(x, scale = 100), "%")),
  all_tests("smd") ~ label_style_sigfig()
)

This could be

estimate_fun = list(
  c(all_continuous(), all_categorical(FALSE)) ~ label_style_sigfig(),
  all_dichotomous() ~ label_style_sigfig(scale = 100, suffix = "%"),
  all_tests("smd") ~ label_style_sigfig()
)

@ddsjoberg ddsjoberg removed the v2.0 🤞🤞 A nice-to-have for the v2.0 release label Jul 13, 2024
@ddsjoberg ddsjoberg removed this from the v2.0.0 milestone Jul 13, 2024
@ddsjoberg ddsjoberg added this to the v2.1.0 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant