-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure with dev glue #1989
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is inspired by doing revdep checks for glue. In the next release of glue, which is very soon,
glue::glue()
will error when.envir
is not an actual environment..envir
has always been documented to be an environment and I've been working to make this actually true.I last did revdep checks for this in December 2023 and I opened issue or PRs everywhere that I could. So gtsummary's usage of this pattern must have arisen more recently.
glue_data()
does officially accept something "list-ish" as.x
. So you should switch toglue_data(.x = list_ish_thing, ...)
as opposed toglue(.envir = list_ish_thing, ...)
in many places here in this package. I haven't made a PR since there seem to be so many locations that need tweaking; I don't trust myself to get this right, quickly, in someone else's package.Relevant links in glue:
tidyverse/glue#308
tidyverse/glue@e2b74ff
tidyverse/glue#341
Here's what I'm currently seeing for gtsummary in glue's revdep checks:
https://github.com/tidyverse/glue/blob/main/revdep/problems.md#gtsummary
I think this breakage has some other indirect effects on gtsummary's revdeps, such as gtreg (cc @shannonpileggi ).
The text was updated successfully, but these errors were encountered: