Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update bundled asciidoctor #136

Closed
sjaeckel opened this issue Jul 25, 2018 · 6 comments
Closed

update bundled asciidoctor #136

sjaeckel opened this issue Jul 25, 2018 · 6 comments
Assignees
@de-jcup
Labels
enhancement New feature or request
Milestone
1.2.0

Comments

@sjaeckel
Copy link

there are some neat features in the latest asciidoctor 1.5.7 branch :)
would it be possible to get an updated version of this plugin which bundles the latest asciidoctor?
@de-jcup de-jcup added the enhancement New feature or request label Jul 25, 2018
@de-jcup
Copy link
Owner

de-jcup commented Jul 25, 2018 •
edited
Loading

Hello @sjaeckel,

the integration of asciidoctor into eclipse (in conjuction with asciidoctorj+ jruby + osgi...) was ... tricky.

Hmm... when looking at
https://github.com/asciidoctor/asciidoctor/milestone/22?closed=1
https://github.com/asciidoctor/asciidoctor/milestone/27?closed=1

There was much going on in 1.5.7.x ... would be nice to get it.

I am currently not sure how much effort it would be to upgrade to 1.5.7. When no update of asciidoctorj and jruby would be necessary, It should be done very fast. But if some of the workarounds I integrated do no longer work with the new version... this could take some time...

I will give it a try - but currently I am extreme busy at my company, so I am not sure when I will be able to start. I start planning for 1.2.0

@de-jcup de-jcup self-assigned this Jul 25, 2018
@de-jcup de-jcup added this to the 1.2.0 milestone Jul 25, 2018
@charleech
Copy link

charleech commented Aug 4, 2018 •
edited
Loading

FYI, the asciidoctorj version 1.5.7 is released as well. The JRuby supported version is 9.1.16.0.

@de-jcup
Copy link
Owner

de-jcup commented Aug 4, 2018 •
edited
Loading

JRuby 9.x is/was a problem. I tried it out when I started the developing of the eclipse plugin and had many problems with it, so I did go back to 1.5.6 and jruby-complete-1.7.26.jar.

Maybe when implementing #69 and give users possibility to use a customized asciidoctorj + jruby setup the users could setup it by their own and if there is a working setup for newer asciidoctorj, the asciidoctor plugin could get some new library setup from community experience which is working well out of the box.

So maybe implementing #69 by customizable external asciidoctor setup and still providing 1.5.6 as embedded and stable variant, maybe this would be the smartest and easiest approach.

@sjaeckel
Copy link
Author

sjaeckel commented Sep 3, 2018

I think so too, as my next question would've been "how can I enable asciidoctor-mathematical?"

@de-jcup
Copy link
Owner

de-jcup commented Sep 3, 2018

#69 will be implemented

@de-jcup de-jcup mentioned this issue Sep 3, 2018
Closed
@de-jcup de-jcup mentioned this issue Sep 17, 2018
Closed
@de-jcup
Copy link
Owner

de-jcup commented Oct 11, 2018

Closed #69 because #147 is now implemented and comes up with 1.2.0
So closing this issue too.

@de-jcup de-jcup closed this as completed Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-jcup de-jcup

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
3 participants
@sjaeckel @charleech @de-jcup