Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: URL validation is too narrow. #2

Open
puellanivis opened this issue Jul 30, 2020 · 2 comments
Open

data: URL validation is too narrow. #2

puellanivis opened this issue Jul 30, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@puellanivis
Copy link

A non-exhaustive list of URIs that fail validation can be seen here: https://play.golang.org/p/pKsNZZ00AKo

Of particular note, most of the example data: URIs given in RFC-2397 do not validate, despite being specific explicitly valid data URIs.

@dealancer
Copy link
Owner

Good catch! Looks like it is a similar issue to go-playground/validator#548. Needs work.

@dealancer dealancer added the bug Something isn't working label Aug 3, 2020
@puellanivis
Copy link
Author

Yeah, there was a poor regex that managed to spread pretty wide to nearly all of the validator packages. This is basically the canary test that I tend to do on every validate library that I find being used in our company. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants