Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that sign-in popup is unreliable (eg. blocked by default on Safari) #312

Closed
Venryx opened this issue May 18, 2024 · 2 comments
Closed

Comments

@Venryx
Copy link
Collaborator

Venryx commented May 18, 2024

No description provided.

@Venryx
Copy link
Collaborator Author

Venryx commented May 22, 2024

Made the change below just now (not yet pushed to GH), in attempt to fix this issue (not yet tested on Safari):

  • MS sign-in panel retrieves the auth-link at time of panel open, rather than time of sign-in-button click. By doing this, the sign-in button can launch the sign-in popup immediately, rather than after a slight delay. (in attempt to fix popup-blocked issue on safari)

@Venryx
Copy link
Collaborator Author

Venryx commented May 22, 2024

After making the attempted fix (in previous comment), M-A did a quick test on a Safari browser, and did not hit the issue. (granted, the issue was unreliable there)

So for now, presuming fixed.

@Venryx Venryx closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant