-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught Type Error coming from browser.js #436
Comments
Yup, feel free to submit a PR :) |
@Camyll are you down to help us with a PR? |
@thebigredgeek sure I can probably get to it by the end of the week. It's just a simple null check for document.documentElement that needs to be added. Checking if it's undefined is not enough |
We could just check a boolean cast. That would be the most error proof. Seems like this kind of stuff continues to creep up |
@thebigredgeek yeah just let me know if you guys want to make the change, if not I can try and get to it soon. Sorry I keep forgetting |
@thebigredgeek @Camyll any info on that? |
#447 <- just waiting on a sanity check |
Great, thanks! |
Looks like #447 was merged. Please let me know if it didn't solve the problem. |
TypeError: Cannot read property 'style' of null happening when document.documentElement is null because there is no null check. Would like to put in a PR to fix it if you guys decide not to.
The text was updated successfully, but these errors were encountered: