Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

olevba: splitlines error on Python 2 when parsing SLK files #797

Closed
decalage2 opened this issue Nov 27, 2022 · 0 comments · Fixed by #769
Closed

olevba: splitlines error on Python 2 when parsing SLK files #797

decalage2 opened this issue Nov 27, 2022 · 0 comments · Fixed by #769
Assignees
@decalage2
Labels
🐛 bug olevba Python 2.7
Milestone
oletools 0.60

Comments

@decalage2
Copy link
Owner

str.splitlines() takes one argument keepends: it is a keyword argument in Python 3, but it is only positional in Python 2.
The following line in open_slk triggers an error with Python 2:

for line in data.splitlines(keepends=False):

The bug is fixed in PR #769
@decalage2 decalage2 added this to the oletools 0.60 milestone Nov 27, 2022
@decalage2 decalage2 self-assigned this Nov 27, 2022
@decalage2 decalage2 linked a pull request Nov 27, 2022 that will close this issue
Fix unittests #769
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@decalage2 decalage2

Labels
🐛 bug olevba Python 2.7
Projects
None yet
Milestone
oletools 0.60
Development

Successfully merging a pull request may close this issue.

Fix unittests christian-intra2net/oletools
1 participant
@decalage2