Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text-editor in NetlifyCMS admin dashboard cannot type any Chinese characters normally #4837

Closed
dev-techmoe opened this issue Jan 11, 2021 · 10 comments
Labels
area: ui/editor good first issue type: bug code to address defects in shipped code

Comments

@dev-techmoe
Copy link

Describe the bug

Any Chinese words cannot be typed into the BODY editor (see GIF below)

To Reproduce

  1. Go to admin dashboard (<site_url>/admin)
  2. Click on "New Blog"
  3. Scroll down to the "BODY" editor area and type some Chinese words with default Chinese IME in Win10 (Microsoft Pinyin)

Expected behavior
see below

Screenshots

image

Applicable Versions:

  • Netlify CMS version: netlify-cms-app 2.12.19
  • Git provider: Github
  • OS: Win10
  • Browser version Chrome 87.0.4280.141

(My site was generated by the "Deploy to Netlify" Button in here, I'm using Gatsby template)

CMS configuration

all using default config

@dev-techmoe dev-techmoe added the type: bug code to address defects in shipped code label Jan 11, 2021
@dev-techmoe dev-techmoe changed the title Text-editor in NetlifyCMS admin dashboard cannot type Chinese characters normally Text-editor in NetlifyCMS admin dashboard cannot type any Chinese characters normally Jan 11, 2021
@xianbinKit
Copy link

the same here

@MannyCooper
Copy link

Really love netlify-cms, please fix this bug soon if possible. This seems to only appear in the BODY editor.

@erezrokah
Copy link
Contributor

Hi all 👋 We would love a contribution for this issue.

@banyudu
Copy link
Contributor

banyudu commented Feb 20, 2021

Can't reproduce in macOS. Have tried Baidu Wubi, Baidu Pinyin, Sogou Wubi, Sogou Pinyin, and the JianTi Pinyin IME comes with macOS.

@inajob
Copy link

inajob commented Mar 13, 2021

Same error in Japanese IME on Windows 10.

@kenchon
Copy link

kenchon commented May 16, 2021

Same bug in following environment (but not occurs in OS X):

Platform OS X (Big Sur) + Chrome Windows 10 + Chrome iOS 14 + Safari/Chrome
Status ✅[1] ❌ [2] ❌ [3]

[1]: cursor behavior is strange, text input always successful
[2]: cursor behavior is strange, text input sometimes fails
[3]: cursor behavior is strange, can't input any texts

@kenchon
Copy link

kenchon commented May 17, 2021

I found similar issue #4539 and this PR #4607 solved this.

@kenchon
Copy link

kenchon commented May 19, 2021

I'm not sure I'm looking properly, as this code shows, markdown editor uses slate-react.
In slate-react project, IME related bugs are reported and I think ours are one of them.

Latest netlify-cms-widget-markdown uses "slate-react": "^0.22.0" and latest is 0.63.0.
Updating slate-react solves some of the issues we found maybe? 😂

@kenchon
Copy link

kenchon commented May 19, 2021

Here describes the root cause of the IME problem, and slate maintainer says this was solved by this PR.

Although there still remains some bugs in IME, updating slate should be the solution of this issue. The problem is updating slate requires many breaking changes ... 🤔

From this point of view, this issue is duplicate of #1347

@erezrokah
Copy link
Contributor

Closing in favor of #1347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui/editor good first issue type: bug code to address defects in shipped code
Projects
None yet
Development

No branches or pull requests

8 participants
@inajob @banyudu @dev-techmoe @xianbinKit @erezrokah @kenchon @MannyCooper and others