Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate collection each entry in the collection search view #945

Closed
erquhart opened this issue Dec 19, 2017 · 4 comments
Closed

Indicate collection each entry in the collection search view #945

erquhart opened this issue Dec 19, 2017 · 4 comments

Comments

@erquhart
Copy link
Contributor

Currently, searching across collections can yield a list of titles, with no indication of what collection they belong to. The collection should be indicated on each item.

@solpark
Copy link
Contributor

solpark commented Jan 31, 2018

I'd like to take this issue! I've figured out how to access the collection name and display it for each found search item, but I'd like to know how and where it should be displayed.

@tech4him1
Copy link
Contributor

@solpark Awesome! Feel free to ask questions on our Gitter channel if you need any pointers.

@erquhart @neutyp @ziburski Can you outline what design we want on this?

@erquhart
Copy link
Contributor Author

erquhart commented Feb 1, 2018

@solpark are you up for proposing a solution that you think works? If so, just submit a pull request! You'll get one or more reviews with suggestions on how things might be improved if necessary. If you'd really like a bit more guidance, though, definitely ask either here or on Gitter as @tech4him1 mentioned :)

@solpark
Copy link
Contributor

solpark commented Feb 1, 2018

Thank you @erquhart and @tech4him1 ! Just opened a pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants