Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement React Hot Loader #966

Closed
tech4him1 opened this issue Dec 25, 2017 · 4 comments · Fixed by #1214
Closed

Re-implement React Hot Loader #966

tech4him1 opened this issue Dec 25, 2017 · 4 comments · Fixed by #1214

Comments

@tech4him1
Copy link
Contributor

React Hot Loader (and HMR in general) was removed in v1.0 since it was not working correctly. There were also some bugs with our transpiler that should both be fixed in RHL v4 (#765 (comment)). We should try to re-add this once it gets stable and working.

@tech4him1
Copy link
Contributor Author

gaearon/react-hot-loader#703 explains the basic changes made to allow v4 work better.

@theKashey
Copy link

React-hot-loader v4.0.0-beta16(aka "next") is super stable and just working.

@erquhart
Copy link
Contributor

Awesome, thanks for the heads up @theKashey

@tech4him1
Copy link
Contributor Author

Caleb @tech4him1 Mar 31 09:24
@theKashey I'm getting back around to implementing RHL v4. Should the hot(module) wrapper be around any Redux Provider's, or just around the root App itself? Thank you!

Anton @theKashey Mar 31 16:13
Should be on top paths you gonna change. Root App is "on top" enought, @tech4him1, but dont use hot and react-dom/mount in one file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants