Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in FileUtils while creating URI on Windows #184

Closed
Julieng50 opened this issue Dec 15, 2017 · 2 comments
Closed

Bug in FileUtils while creating URI on Windows #184

Julieng50 opened this issue Dec 15, 2017 · 2 comments

Comments

@Julieng50
Copy link
Contributor

Julieng50 commented Dec 15, 2017

Hi !
There is a bug in the method :

    // org.pf4j.util.FileUtils line 216
    public static Path getPath(Path path, String first, String... more) throws IOException {
        URI uri = path.toUri();
        if (isJarFile(path)) {
            uri = URI.create("jar:file:" + path.toString());
        }

        return getPath(uri, first, more);
    }

You must force "\" to "/" while doing path.toString() for Jar files.

The error is :
Illegal character in opaque part at index 11: jar:file:D:\Dev\WorkingDir\projectName\plugins\plugin-pluginName.jar

@decebals
Copy link
Member

Use 2.1.0-SNAPSHOT.

@Julieng50
Copy link
Contributor Author

Julieng50 commented Dec 16, 2017

Thanks for your reactivity :)
BUILD is a success
TESTS are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants