Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties Descriptor finder bug fixes and a test #129

Merged
merged 2 commits into from
Mar 30, 2017

Conversation

janhoy
Copy link
Member

@janhoy janhoy commented Mar 30, 2017

Adding parsing of plugin.description and plugin.requires to the properties finder, and added a test

@coveralls
Copy link

coveralls commented Mar 30, 2017

Coverage Status

Coverage increased (+2.7%) to 17.875% when pulling 047b8d9 on cominvent:properties-descriptor-finder into e9126c4 on decebals:master.

@@ -0,0 +1,177 @@
package ro.fortsoft.pf4j;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the copyright header (copy/paste from other .java file).

@coveralls
Copy link

coveralls commented Mar 30, 2017

Coverage Status

Coverage increased (+2.7%) to 17.875% when pulling 26cbed5 on cominvent:properties-descriptor-finder into e9126c4 on decebals:master.

@decebals decebals merged commit c6aa1f1 into pf4j:master Mar 30, 2017
@decebals
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants