Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getVersion() use wrong class for calculating PF4J version #134

Merged
merged 1 commit into from
Apr 3, 2017

Conversation

janhoy
Copy link
Member

@janhoy janhoy commented Apr 3, 2017

I have a custom PluginManager, and when the getVersion() code attempts to log PF4J's version in initialize(), it uses getClass() to fetch implementationVersion. This assumes that getClass returns a PF4J class, but it returns my own class, which incidentially has a version not parsable by semVer Version class (it contains a space and git hash after the version string).

The fix is to always use a pf4j class for calculating the version.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 23.718% when pulling 69601ec on cominvent:version-print-bugfix into aef9d3a on decebals:master.

@coveralls
Copy link

coveralls commented Apr 3, 2017

Coverage Status

Coverage remained the same at 23.692% when pulling 69601ec on cominvent:version-print-bugfix into aef9d3a on decebals:master.

@decebals decebals merged commit 042fec5 into pf4j:master Apr 3, 2017
@decebals
Copy link
Member

decebals commented Apr 3, 2017

Thanks!

@janhoy janhoy deleted the version-print-bugfix branch April 3, 2017 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants