Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete plugin zip on uninstall #136

Merged
merged 2 commits into from
Apr 3, 2017
Merged

Delete plugin zip on uninstall #136

merged 2 commits into from
Apr 3, 2017

Conversation

janhoy
Copy link
Member

@janhoy janhoy commented Apr 3, 2017

Delete plugin zip file from pluginsRoot as part of deletePlugin(id)

@coveralls
Copy link

coveralls commented Apr 3, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.1%) to 25.443% when pulling 343f1a5 on cominvent:zip-delete into a77245a on decebals:master.

decebals
decebals reviewed Apr 3, 2017
View reviewed changes
pf4j/src/main/java/ro/fortsoft/pf4j/util/FileUtils.java Outdated
* Delete a file (not recursively) and ignore any errors
* @param path the path to delete
*/
public static void optimisiticDelete(Path path) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong spelling for optimistic ?

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 25.443% when pulling cab5359 on cominvent:zip-delete into a77245a on decebals:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 25.443% when pulling cab5359 on cominvent:zip-delete into a77245a on decebals:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 25.443% when pulling cab5359 on cominvent:zip-delete into a77245a on decebals:master.

@decebals decebals merged commit f4ddddc into pf4j:master Apr 3, 2017
@decebals
Copy link
Member

decebals commented Apr 3, 2017

Thanks!

@janhoy janhoy deleted the zip-delete branch April 3, 2017 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decebals decebals decebals left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janhoy @coveralls @decebals