Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The requires Expression does not print well #137

Merged
merged 1 commit into from
Apr 3, 2017
Merged

The requires Expression does not print well #137

merged 1 commit into from
Apr 3, 2017

Conversation

janhoy
Copy link
Member

@janhoy janhoy commented Apr 3, 2017

Instead we get the className. As I could not find any method on Expression to convert back to String, this fix adds a requiresString variable to PluginInfo.

@janhoy
The requires Expression does not print well, instead we get the class…
e3e1823 
…Name. This fix adds a `requiresString` to PluginInfo.
@coveralls
Copy link

coveralls commented Apr 3, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 25.519% when pulling e3e1823 on cominvent:requires-as-string into f4ddddc on decebals:master.

@decebals decebals merged commit edbb541 into pf4j:master Apr 3, 2017
@decebals
Copy link
Member

decebals commented Apr 3, 2017

Make sense. Thanks!

@janhoy janhoy deleted the requires-as-string branch April 3, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janhoy @coveralls @decebals