Kotlin plugin example added and README updated for Kotlin. #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
decebals
requested changes
Jun 9, 2017
| @@ -0,0 +1,31 @@ | |||
| package ro.fortsoft.pf4j.demo.kotlin | |||
There was a problem hiding this comment.
Please add Copyright header. Take it from an existent java file.
There was a problem hiding this comment.
Copyright notice added
There was a problem hiding this comment.
If there is anything pending from my end please let me know.
decebals
reviewed
Jun 9, 2017
| @@ -0,0 +1,46 @@ | |||
| /* | |||
| * Copyright 2017 Anindya Chatterjee | |||
There was a problem hiding this comment.
Copyright (C) 2017 the original author or authors. ?
You are the author of this class so I don't see a problem with my propose. A copy/paste from an existed .java file is fine. Do you see a problem?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.