Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CompoundPluginDescriptorFinder #172

Merged
merged 7 commits into from
Oct 4, 2017
Merged

Add CompoundPluginDescriptorFinder #172

merged 7 commits into from
Oct 4, 2017

Conversation

decebals
Copy link
Member

A POC (proof of concept) for #143 (comment).

@coveralls
Copy link

coveralls commented Sep 27, 2017

Coverage Status

Coverage decreased (-0.2%) to 54.644% when pulling af6e3c8 on compound into da346cf on master.

@decebals decebals requested review from janhoy and removed request for janhoy October 2, 2017 17:20
…nder and remove DefaultPluginDescriptorFinder
@coveralls
Copy link

coveralls commented Oct 2, 2017

Coverage Status

Coverage increased (+0.3%) to 55.196% when pulling 9b2e496 on compound into da346cf on master.

@janhoy
Copy link
Member

janhoy commented Oct 3, 2017

Looks nice. I can give more feedback once I try to move from my homegrown solution to this one. But that won't happen until next week or so.

@coveralls
Copy link

coveralls commented Oct 3, 2017

Coverage Status

Coverage increased (+0.3%) to 55.184% when pulling 8db677b on compound into da346cf on master.

@coveralls
Copy link

coveralls commented Oct 3, 2017

Coverage Status

Coverage increased (+0.3%) to 55.184% when pulling 95d3d1e on compound into da346cf on master.

@coveralls
Copy link

coveralls commented Oct 3, 2017

Coverage Status

Coverage increased (+0.3%) to 55.184% when pulling 01fa88f on compound into da346cf on master.

@coveralls
Copy link

coveralls commented Oct 3, 2017

Coverage Status

Coverage increased (+0.4%) to 55.241% when pulling 482b32c on compound into da346cf on master.

@coveralls
Copy link

coveralls commented Oct 4, 2017

Coverage Status

Coverage increased (+0.7%) to 55.518% when pulling 1a0b585 on compound into da346cf on master.

@decebals decebals merged commit 1822cde into master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants