Add Plugin status provider #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Decebal Suiu » pf4j #96 SUCCESS |
|
Can you please describe in few words your use case or the user case resolved by this PR? |
|
I want the plugins enable/disable configuration to be fetch from a database, this allows the user to change this configuration in the interface. |
| @@ -658,6 +658,37 @@ protected PluginClasspath createPluginClasspath() { | |||
| return new PluginClasspath(); | |||
| } | |||
|
|
|||
| protected PluginStatusProvider createPluginStatusProvider() { | |||
| return new PluginStatusProvider() { | |||
There was a problem hiding this comment.
My idea is to move the default implementation in a DefaultPluginStatusProvider.
There was a problem hiding this comment.
Ok, I will update that.
|
Updated. |
|
Decebal Suiu » pf4j #99 SUCCESS |
|
👍 Good job. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.