Replace Version with semver lib #44
Conversation
|
My philosophy (see my projects, pippo for example) is to keep the number of dependencies as low as possible, because people/users want this. I add a new dependency only if that library brings value in project. |
|
I understand that and the value that the lib brings is the support for semver ranges (https://github.com/zafarkhaja/jsemver#semver-expressions-api-ranges) that I'm going to need for compatibility check of plugins. |
|
Thanks for your explanation. Can you comment on how you see #32 implementation to have a common understanding? |
|
I still thinking about it because I want to use the process information of the graph to do the validations. But as a big picture I just going to put the plugin with the disable state if some of his dependencies are disabled. This with some error reporting information is enough for me. |
|
@gitblit I think that it's a good idea to have range validation on plugin version and I think that the |
|
It's ok with me. |
Replace Version with semver lib
| private String pluginVersionSupport; | ||
|
|
||
| public PluginDependency(String dependency) { | ||
| int index = dependency.indexOf('@'); |
There was a problem hiding this comment.
For me the syntax plugin-at-version makes more sense but I saw that you were using : and forgot to change it.
First Step to #32