Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcl build - doesn't return exit code on error #551

Open
sfoxdev opened this issue Apr 3, 2021 · 0 comments
Open

dcl build - doesn't return exit code on error #551

sfoxdev opened this issue Apr 3, 2021 · 0 comments

Comments

@sfoxdev
Copy link

sfoxdev commented Apr 3, 2021

Using command dcl build in CI/CD doesn't return exit code on error.

> dcl build
Decentraland CLI sends anonymous usage stats to improve their products, if you want to disable it change the configuration at ~/.dclinfo
Building project using "npm run build"
> dcl-project@1.0.0 build /home/runner/work/test-project/test-project
> build-ecs
> Working directory: /home/runner/work/test-project/test-project
> processing /src/game.ts
  Error /src/modules/overlay/OverlayUI.ts (16,7): Cannot find name 'setInterval'.
  Error /src/modules/poker/Ball.ts (106,11): Cannot find name 'setTimeout'.
> writing /bin/game.js
> writing /bin/game.js.lib

as result automated build continue and deploy scene with errors.

Command dcl must return exit, so build will fail and then devs can fix problem and re-commit.

@menduz menduz transferred this issue from decentraland/issues May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant