Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect links #2

Closed
JanLin opened this issue Jan 26, 2023 · 3 comments
Closed

incorrect links #2

JanLin opened this issue Jan 26, 2023 · 3 comments
Assignees

Comments

@JanLin
Copy link

JanLin commented Jan 26, 2023

Small issue. Two links are incorrect.
https://didcomm.org/mydata-did/2.0 leads nowhere
and
Data Disclosure Agreement (DDA)

correct one
https://github.com/decentralised-dataexchange/data-exchange-agreements/blob/main/interface-specs/jsonld/contexts/dexa-context.jsonld

@lalc
Copy link
Member

lalc commented Jan 26, 2023

Which are the effected files @JanLin?

@lalc lalc self-assigned this Jan 26, 2023
@JanLin
Copy link
Author

JanLin commented Jan 26, 2023

Sorry, missed to point at section. This is where didcomm was incorrect. And next section "create" has incorrect DDA link.

https://github.com/decentralised-dataexchange/data-exchange-agreements/blob/main/docs/did/spec.md#operations

@lalc lalc closed this as completed in adf2ddf Jan 26, 2023
@lalc
Copy link
Member

lalc commented Jan 26, 2023

Fixed. Pls, note that https://didcomm.org/mydata-did/2.0 is not an URL but a DIDComm v1 message type prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants