Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated publicKey attribute 'owner' to 'controller' #55

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Updated publicKey attribute 'owner' to 'controller' #55

merged 1 commit into from
Aug 14, 2020

Conversation

aceshim
Copy link
Contributor

@aceshim aceshim commented Aug 13, 2020

According to the latest W3C DID spec, a publicKey property MUST have id, type, and controller. (https://www.w3.org/TR/did-core/#public-keys)

As far as I know, owner property is legacy named before the spec was written. #54

So I changed the owner to controller to comply with the spec.

@aceshim aceshim mentioned this pull request Aug 13, 2020
Closed
mirceanis
mirceanis approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@mirceanis mirceanis merged commit 850e5a5 into decentralized-identity:master Aug 14, 2020
uport-automation-bot pushed a commit that referenced this pull request Aug 14, 2020
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
ebb6262 
# [2.1.0](2.0.1...2.1.0) (2020-08-14)

### Features

* rename PublicKey attribute 'owner' to 'controller' ([#55](#55)) ([850e5a5](850e5a5)), closes [#54](#54)
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@uport-automation-bot uport-automation-bot added the spec more parties need to agree label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
spec more parties need to agree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aceshim @uport-automation-bot @mirceanis