Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display dates for upcoming moderated meetings #12295

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Jan 15, 2024

🎩 What? Why?

This PR hides the moderated upcoming meeting date from assembly and conferences cards.

📌 Related Issues

Link your PR to an issue

Testing

  1. Visit the website, and click find , select Assemblies
  2. In the Assembly cards, you should be able to see a text labeled " Upcoming meeting "
  3. Visit the assembly, and hide (moderate) all meetings
  4. Refresh the search results.
  5. See the " Upcoming meeting " is still present
  6. Apply patch (since we are changing the initializer, an application restart is required)
  7. See the meeting date is not being shown

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu added module: meetings type: fix PRs that implement a fix for a bug no-backport Pull Requests that should not be backported release: v0.27 Issues or PRs that need to be tackled for v0.27 labels Jan 15, 2024
@alecslupu alecslupu marked this pull request as ready for review January 18, 2024 14:24
@alecslupu alecslupu added this to the 0.27.6 milestone Jan 18, 2024
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this is working for moderated meetings, but there are a couple more cases that we need to take into account:

Unpublished

According to the scope in this code it should not happen, but I can see it. Can you add a spec for this case?

Backend showing an unpublished meeting
Frontend showing an unpublished upcoming meeting

Withdrawn

Can you fix this case and add an spec?

Frontend showing the page of a withdrawn meeting
Frontend showing a withdrawn upcoming meeting

Thanks!

@alecslupu alecslupu assigned alecslupu and unassigned andreslucena Jan 26, 2024
@alecslupu
Copy link
Contributor Author

@andreslucena , the changes requested have been implemented in eb85c0d

Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ron Swanson from Parks and Recreations saying "it's so beautiful"

@andreslucena andreslucena merged commit 42acd38 into release/0.27-stable Jan 30, 2024
15 checks passed
@andreslucena andreslucena deleted the fix/upcoming-meetings branch January 30, 2024 13:08
@alecslupu alecslupu linked an issue Feb 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: meetings no-backport Pull Requests that should not be backported release: v0.27 Issues or PRs that need to be tackled for v0.27 type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upcoming meetings displays moderated meetings
2 participants