Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractAnvilDisposable - GC.SuppressFinalize #37

Open
jkeon opened this issue Jun 17, 2020 · 0 comments
Open

AbstractAnvilDisposable - GC.SuppressFinalize #37

jkeon opened this issue Jun 17, 2020 · 0 comments
Labels
effort-low Easy - 1 to 2 hours priority-medium Standard task, plan as you see fit. status-todo Tasks ready to be worked on. type-chore Clean-up and optimization
Milestone
Anvil v1.0

Comments

@jkeon
Copy link
Member

jkeon commented Jun 17, 2020

Looking at the docs for IDisposable https://docs.microsoft.com/en-us/dotnet/api/system.idisposable?view=netcore-3.1

Should we change anything with our AbstractAnvilDisposable keeping in mind that we like to use this for most of our classes and performance considerations as mentioned here:

https://raygun.com/blog/c-sharp-performance-tips-tricks/

See point 7.
@jkeon jkeon added effort-low Easy - 1 to 2 hours priority-medium Standard task, plan as you see fit. status-todo Tasks ready to be worked on. type-chore Clean-up and optimization labels Jun 17, 2020
@jkeon jkeon added this to the Anvil v1.0 milestone Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort-low Easy - 1 to 2 hours priority-medium Standard task, plan as you see fit. status-todo Tasks ready to be worked on. type-chore Clean-up and optimization
Projects
None yet
Milestone
Anvil v1.0
Development

No branches or pull requests
1 participant
@jkeon