Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UB #29

Closed
2 tasks done
EllipticEllipsis opened this issue Oct 17, 2022 · 1 comment
Closed
2 tasks done

Fix UB #29

EllipticEllipsis opened this issue Oct 17, 2022 · 1 comment

Comments

@EllipticEllipsis
Copy link
Contributor

EllipticEllipsis commented Oct 17, 2022

Goal: get a whole project to compile with ASAN on

Currently known UB:

  • wrapper___ll_mul will cause UB if multiplicands are too large (known to occur in cfe). Proposed solution: cast the multiplicands to unsigned first.
  • wrapper___ll_lshift will cause UB if shift is too large (occurs in OoT z_en_ossan.c)
@hensldm
Copy link
Contributor

hensldm commented Oct 21, 2022

Fixed in #31

@hensldm hensldm closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants