This repository has been archived by the owner on Jun 4, 2018. It is now read-only.
Add vote preference stakepool integration. #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the stakepool client to support the v2 API which can be used to set vote preferences, and updates to a newer version of the wallet gRPC API to support saving and retreiving vote preferences from the wallet DB. All agendas in the latest support stake version are now shown in the purchase tickets view with dropdown boxes for users to select their vote preference on an agenda. Whenever a choice is changed, the local vote preferences are saved by the wallet and each configured stakepool is updated through the API. Note that vote preferences are never read through the stakepool API. If a user changes their preferences through another channel (e.g. the stakepool web UI, or other wallet software) the update will not be visible in Paymetheus and Paymetheus may overwrite preferences when additional modifications are made. This is unfortunate but I don't see a better way of handling this considering that multiple stakepools may be configured, each with different vote preferences. Closes #240.
marcopeereboom
approved these changes
Apr 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the stakepool client to support the v2 API which can be
used to set vote preferences, and updates to a newer version of the
wallet gRPC API to support saving and retreiving vote preferences from
the wallet DB.
All agendas in the latest support stake version are now shown in the
purchase tickets view with dropdown boxes for users to select their
vote preference on an agenda. Whenever a choice is changed, the local
vote preferences are saved by the wallet and each configured
stakepool is updated through the API.
Note that vote preferences are never read through the stakepool API.
If a user changes their preferences through another channel (e.g. the
stakepool web UI, or other wallet software) the update will not be
visible in Paymetheus and Paymetheus may overwrite preferences when
additional modifications are made. This is unfortunate but I don't
see a better way of handling this considering that multiple stakepools
may be configured, each with different vote preferences.
Closes #240.