This repository has been archived by the owner on Jun 4, 2018. It is now read-only.
Improve UX of the purchase ticket view. #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcopeereboom
approved these changes
May 22, 2017
This change removes the split tx (this can be always be left as the default, and should use a configured relay fee instead of being a separate option) and renames the "Ticket fee" field to "Ticket transaction fee" to make it clearer that it is a transaction fee and is unrelated to the ticket price. While here, drastically improve the XAML for the view by removing an unnecessary grid column, unnecessary grid and row spans, unnecessary margins and offsets that should be handled by the grid itself, and inconsistent styling of elements.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the split tx (this can be always be left as the
default, and should use a configured relay fee instead of being a
separate option) and renames the "Ticket fee" field to "Ticket
transaction fee" to make it clearer that it is a transaction fee and
is unrelated to the ticket price.
While here, drastically improve the XAML for the view by removing an
unnecessary grid column, unnecessary grid and row spans, unnecessary
margins and offsets that should be handled by the grid itself, and
inconsistent styling of elements.
Closes #261
Closes #281