rpcserver: Improve JSON-RPC compatibility #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid compatibility issues with software relying on Core's behavior, terminate HTTP POST JSON-RPC responses with a newline.
Avoid compatibility issues with software that relies on the behavior of bitcoind's JSON-RPC implementation. The JSON-RPC 1.0 spec defines that notifications must have their "id" set to null and states that notifications do not have a response. A JSON-RPC 2.0 notification is a request with "json-rpc":"2.0", and without an "id" member. The specification states that notifications must not be responded to. JSON-RPC 2.0 permits the null value as a valid request id, therefore such requests are not notifications. Bitcoin Core serves requests with "id":null or even an absent "id", and responds to such requests with "id":null in the response. Btcd does not respond to any request without and "id" or with "id":null, regardless the indicated JSON-RPC protocol version. In order to avoid compatibility issues with software relying on Core's behavior, this commit implements "quirks mode" as follows: - quirks mode can be enabled via configuration (disabled by default) - If no JSON-RPC version is indicated in the request, accept and respond to request with "id":null - If no JSON-RPC version is indicated in the request, accept and respond to requests without an "id" member - In both cases above, use "id":null in the response - Do not respond to request without an "id" or with "id":null when JSON-RPC version is indicated in the request (process as notification)
In order to avoid compatibility issues with software relying on Core's behavior, terminate HTTP POST JSON-RPC responses with a newline.
Avoid compatibility issues with software that relies on the behavior of bitcoind's JSON-RPC implementation. The JSON-RPC 1.0 spec defines that notifications must have their "id" set to null and states that notifications do not have a response. A JSON-RPC 2.0 notification is a request with "json-rpc":"2.0", and without an "id" member. The specification states that notifications must not be responded to. JSON-RPC 2.0 permits the null value as a valid request id, therefore such requests are not notifications. Bitcoin Core serves requests with "id":null or even an absent "id", and responds to such requests with "id":null in the response. Btcd does not respond to any request without and "id" or with "id":null, regardless the indicated JSON-RPC protocol version. In order to avoid compatibility issues with software relying on Core's behavior, this commit implements "quirks mode" as follows: - quirks mode can be enabled via configuration (disabled by default) - If no JSON-RPC version is indicated in the request, accept and respond to request with "id":null - If no JSON-RPC version is indicated in the request, accept and respond to requests without an "id" member - In both cases above, use "id":null in the response - Do not respond to request without an "id" or with "id":null when JSON-RPC version is indicated in the request (process as notification)
davecgh
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following upstream commits:
In order to avoid compatibility issues with software relying on
Core's behavior, terminate HTTP POST JSON-RPC responses with a newline.