Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy: Lower default relay fee to 0.0001/kB. #1202

Merged
merged 1 commit into from
May 26, 2018

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented May 11, 2018

This lowers the default minimum relay fee to 0.0001 DCR/Kb from its previous value of 0.001 DCR/Kb and increases the high fee multiplier to keep the same default high fee threshold of 1 DCR/kB.

In order to keep the comments accurate, it also updates the comments in the isDust function and the sample config file to match the new default relay fee as it's nice to have the most recent values as a reference in the comments.

Finally, it updates the tests for the expected new values as a result of the reduced default relay fee and adds add a couple of dust tests just below and above the dust point for the new reduced default relay fee.

It should be noted that this is only a default node policy change and as such does not affect the consensus rules in any way.

@davecgh davecgh added this to the 1.3.0 milestone May 12, 2018
This lowers the default minimum relay fee to 0.0001 DCR/Kb from its
previous value of 0.001 DCR/Kb and increases the high fee multiplier to
keep the same default high fee threshold of 1 DCR/kB.

In order to keep the comments accurate, it also updates the comments in
the isDust function and the sample config file to match the new default
relay fee as it's nice to have the most recent values as a reference in
the comments.

Finally, it updates the tests for the expected new values as a result of
the reduced default relay fee and adds add a couple of dust tests just
below and above the dust point for the new reduced default relay fee.

It should be noted that this is only a default node policy change and as
such does not affect the consensus rules in any way.
@davecgh davecgh force-pushed the multi_lower_default_relay_fee branch from b575dc4 to 7a457fc Compare May 26, 2018 14:45
@davecgh davecgh merged commit 7a457fc into decred:master May 26, 2018
@davecgh davecgh deleted the multi_lower_default_relay_fee branch May 26, 2018 14:58
@JFixby
Copy link
Contributor

JFixby commented May 26, 2018

@davecgh there could be an issue with ; minrelaytxfee=0.0001 parameter in sample config:

  1. Someone has the old value in his config
  2. He updates the code/dcrd version
  3. forgets (because doesn't know about it) to update the parameter in his config and keeps the old value

suggestion: introduce a new parameter name for the minrelaytxfee=0.0001 and deprecate the old one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants