multi: modify PurchaseTicketCmd. #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
reviewed
May 31, 2018
rpcclient/wallet.go
Outdated
| @@ -803,7 +803,7 @@ func (c *Client) PurchaseTicketAsync(fromAccount string, | |||
| ticketFeeFloat = ticketFee.ToCoin() | |||
| } | |||
|
|
|||
| splitTxVal := uint32(1) | |||
| splitTxVal := false | |||
There was a problem hiding this comment.
Instead of defaulting to one or the other, since it will also be specified in the wallet config, the JSON null could be used to not explicitly set the option in the RPC parameters, but use the configured option instead.
dnldd
force-pushed
the
change_split_tx_type
branch
from
572b4cc
to
ecf5586
Compare
This renames the SplitTx field to TicketChange since it better describes the feature being opted into. The field type was also changed to a bool pointer.
dnldd
force-pushed
the
change_split_tx_type
branch
from
ecf5586
to
7ae66c8
Compare
jrick
approved these changes
May 31, 2018
dnldd
changed the title
davecgh
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the SplitTx field to TicketChange since it better describes
the feature being opted into. The field type was also changed to a bool
pointer.