multi: remove chainState deps in server & cpuminer. #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
rm_chainstate_server_and_cpuminer
branch
3 times, most recently
from
88cebec
to
b837015
Compare
dnldd
force-pushed
the
rm_chainstate_server_and_cpuminer
branch
from
b837015
to
5de2819
Compare
matheusd
reviewed
Sep 11, 2018
mempool/mempool.go
Outdated
| // | ||
| // TODO: Ideally this would not return an error, but changing the function | ||
| // would require a major version bump to the mempool module. | ||
| // The next time a major version is released, the error should be removed. |
There was a problem hiding this comment.
While this is true for the particular implementation currently used in this PR, the point of decoupling the structures by using a function reference is that you don't need to know whether the impl returns an error or not. So I'd say that you should just maintain this function signature and the subsequent error checking.
mining.go
Outdated
| best := blockManager.chain.BestSnapshot() | ||
| prevHash := best.Hash | ||
| nextBlockHeight := best.Height + 1 | ||
| if prevHash != best.Hash || |
There was a problem hiding this comment.
Does this check make sense, given that you just set prevHash := best.Hash? What could cause them to not be equal?
It seems that given you're now using BestSnapshot exclusively (vs using chainState) this whole test can be dropped as it doesn't make sense anymore (bestSnapshot should not change during its lifetime).
dnldd
force-pushed
the
rm_chainstate_server_and_cpuminer
branch
4 times, most recently
from
0a3cef6
to
b1c75f2
Compare
davecgh
requested changes
Sep 12, 2018
dnldd
changed the title
dnldd
force-pushed
the
rm_chainstate_server_and_cpuminer
branch
from
b1c75f2
to
346e582
Compare
This was referenced Sep 12, 2018
dnldd
force-pushed
the
rm_chainstate_server_and_cpuminer
branch
from
346e582
to
c0b0b6c
Compare
davecgh
approved these changes
Sep 12, 2018
This was referenced Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires #1417 and #1418.
Port of upstream commit 2274d36 (subset). In preparation of the
removal of chainState.